afterstep

Ethan Fischer (allanon@u.washington.edu)
Wed, 6 May 1998 20:25:08 -0700 (PDT) 


> Well, not to sound ungreatful but... this is a terrible patch.  Removing
> files and then re-adding the same files in the patch - what's that all
> about?  And the BUGS, I guess removing the "buggy" functionality is one
> way to remove the bugs; not what I would have chosen though.

I'm the person who posted 1.4.5.4 to f.a.o.  I didn't make that patch, 
but I have been working on AS, and any changes to menus in the last 
week or so you can attribute to me.  I've been trying to make improvements, 
but what I've done so far has been mainly to benefit me.  Any suggestions 
you can make are welcome...

> As for one, the feel 130 (transparent) toggle for the menus moving to 129
> (was one pixmap entire menu). I always run my window manager and, as it
> was under 1.4.5.3 - it was buggy, but still worked!  As I see it, my X is
> always up and once you went theough the motions of using:
> 	TextureTypes     128        128      128       128       128
> then initializing it, then going back to:
> 	TextureTypes     128        128      128       129       128
> then menu had the entire pixmap.  The bug in this was if you
> re-initialized the look.file - it lost it and went transparent - with the
> still *unacceptible* bug of not removing the highlight when transparent!
> Personally I'd rather wait a couple weeks for a patch that fixed things
> not removed and replaced them with other still buggy functions.

Wow, this sounds like a lot of work to get the whole menu pixmapped.  I 
had no idea you could do that...  Honestly, when I wrote the patch to 
DrawMenuBorders that made the whole menu pixmapped, I hadn't noticed that 
there was already an option (129) to do so.

That said, it seems to me like this should really be a separate option.  
What if you wanted a transparent pixmap which mapped the whole menu?  
What if you wanted one which did each menu item?  I know I would prefer 
a toggle, not a new texture type.

> p.s. A changelog would be nice too; sure I could just look at the patch,
> but this one made no sense....okay that file is being removed...ah,
> no...wait, it's getting added again...hmmm. :)

Hmm.  Guylhem sent me that patch, and I spent almost no time looking at 
it. ;)  Basically all I wanted it for was so I could fix up my new patches 
to send to him, and the src/ dir patched just fine.

So while I can't help with any changes he may have made, here's an 
overview of what I did:

o SearchIcon defaults to tmp_win->icon_bitmap_file, so default icons work
o UpdateMenu remembers Tmp_win, so menus don't forget that the "Quit" 
  option should be stippled
o stippled menu items can no longer be selected
o MeltStartMenu changed significantly:
 o all submenus are given a unique ID, so they cannot be confused (eg, 
   two copies of the "Games" submenu)
 o if the first word of a file is a reserved word (eg, "Restart"), the 
   file contents are passed through unmodified.  the contents of such 
   a file *must* be a complete, valid line for the config file, or 
   AfterStep will exit with an error
 o the "Start" menu is treated just like its subdirectories, except for 
   the name (which is not given an ID)
 o the hardcoded "Desktop", "Modules", and "Quit" menus are removed
 o the "Look", "Feel", and "Pictures" submenus are still hardcoded, 
   however.  to place them in the menu, just make an empty subdir with 
   the appropriate name, and it will automagically be filled in
o menus now scroll

And I wrote some other patches that didn't make it in.

I've never used Enlightenment, or transparent anything in X.  So I'm 
not sure what there is to be gained by it.  What sort of effect should 
I be looking for with transparency (so I know what I'm shooting for)?

You were saying something is buggy above.  What is the bug, exactly?

BTW, AfterStep 1.4.5.5 (in full) should be on f.a.o real soon now.

----
Ethan Fischer
allanon@u.washington.edu
http://weber.u.washington.edu/~allanon