[as-devel] Re: [julian@catchen.org: Zharf Patch]

Sasha Vasko/OSCA/Courts/Judicial(sashav@sprintmail.com)
Tue, 20 Mar 2001 09:05:35 -0600 


> On Mon, 19 Mar 2001 14:46:59 Sasha Vasko/OSCA/Courts/Judicial wrote:
> > 
> > It looks pretty good. I've added that to CVS.
> > Several things : 
> > 
> > 1) when using stuff coming out of config parser  - no need to do any 
kind
> of 
> > stripping, since parser already does all the stripping needed, so 
> > 
> > ZharfFore = stripcpy(MyConfig->fore);
> > 
> > and the likes aren't really needed. mystrdup() is sufficient.
> > 
> > 2) Now since you keep copy of MyConfig at all times it would be
> > preferrable 
> > 
> > to get rid of things like SharfFore altogether and use MyConfig->fore 
> > everywhere
> > instead. Idea is to remove as much dead code as possible.
> > 
> 
> I will make the changes you suggest above.  One question:  It is probably
> useful to
> keep the Buttons[] array because it requires a decent amount of parsing 
to
> use it,
> although it could be replaced with something like a linked list to remove
> the hard
> limit to the number of buttons.  However, since you plan on dropping
> support in 
> the near future, it may not be worth the effort.  Which approach would 
you
> prefer
> regarding this data structure?

Wharf is using tree-like structure consisting of record of 2 types - 
folders 
and buttons.

> 
> > 3) If we create patches - we use unified diff. There is usefull script: 

> > tools/makeaspatch
> > that should do everything we need, Or simply do 
> > 
> > diff -Nur
> > 
> > Now about Zharf as a separate module. It does essentially same as 
Wharf, 
> > except for the fact that it supplies labels on buttons. Originally it 
was
> ..
> > So for now, since these plans are still plans and no more, I've added
> > patch 
> > for Zharf 
> > in, but I'd rather see any usefull work being performed of Wharf rather 

> > then on Zharf.
> 
> I will finish cleaning up Zharf and then move on to Wharf.  I was only
> working
> on it because Andrew said it needed the work done.  I actually don't use 
> Zharf in my own AS config and would prefer to work on Wharf anyway.
> I plan on redoing the parsing as I can probably share a lot of code 
between
> the two modules. Let me know if there is anything specific you want done.

Actually Wharf has already been rewritten to use libasConfig. What needs to 
be 
updated is drawing code ( to use MyLook and MyWidgets ), and some option 
added
to allow for different look of buttons (with/without label). Another 2 
items that 
has to be taken care of are intermnodule communication and module startup ( 
it has 
to use InitApp for command line args processing ).


You should have commit access to CVS now. You may need to recheckout it 
under 
your name now. Please let me know if you encounter any problems.


Cheers
Sasha