[as-devel] Re: [julian@catchen.org: Zharf Patch]
Sasha Vasko/OSCA/Courts/Judicial(sashav@sprintmail.com)
Mon, 19 Mar 2001 15:46:59 -0600
Andrew forwarded it to me .
> ---------------
>
>
> On Mon, 19 Mar 2001 09:14:22 julian@catchen.org wrote:
> Andrew,
>
> Attached is my first attempt at modifing Afterstep. It is a "diff -c" of
> the Zharf directory. I made changes to Zharf.h and Zharf.c to use the
new
> parsing structures. The module still does not compile, however, I fixed
> all of the warnings/errors coming from the parsing routines. I am not
sure
> if this is Ok, or if you would expect that upon fixing the parsing stuff,
> everyting would compile. I only made the "Config" directories and the
> Zharf directories, so maybe I just haven't built all the needed
libraries.
It looks pretty good. I've added that to CVS.
Several things :
1) when using stuff coming out of config parser - no need to do any kind
of
stripping, since parser already does all the stripping needed, so
ZharfFore = stripcpy(MyConfig->fore);
and the likes aren't really needed. mystrdup() is sufficient.
2) Now since you keep copy of MyConfig at all times it would be preferrable
to get rid of things like SharfFore altogether and use MyConfig->fore
everywhere
instead. Idea is to remove as much dead code as possible.
3) If we create patches - we use unified diff. There is usefull script:
tools/makeaspatch
that should do everything we need, Or simply do
diff -Nur
Now about Zharf as a separate module. It does essentially same as Wharf,
except for the fact that it supplies labels on buttons. Originally it was
intended as a
more powerfull replacement for Wharf by Ghuylhem Aznar, but Ethan Fischer
rewrote
Wharf after that and made it much more powerfull then Zharf. One thing
Wharf is missing
still is labels. One of the latest developments was adding powerfull widget
management code to libasGUI (mywidget.c) . It was an idea that all the
modules
eventually should use this library to do drawing/layout of its GUI. Thus
removing low
level drawing code out of modules. Wharf had to be rewritten using it as
well,
and while at it it was planned to add labels capability to it. Needless to
say
that such development would allow to reduce number of modules by removing
Zharf.
So for now, since these plans are still plans and no more, I've added patch
for Zharf
in, but I'd rather see any usefull work being performed of Wharf rather
then on Zharf.
>
> Anyway, please take a look at the changes and let me know if they are
> acceptable. I would appreciate feedback if I am not following the your
> syntactical conventions or if there are other problems.
>
> If everything is OK, I will continue tonight with more work.
Please send me your username and password (password encoded with standard
unix password hash)
and I'll add commit access for you, so you can work directly with CVS.
Also please make sure you are subscribed to as-devel mailing list :
To subscribe using the standard method:
mail majordomo@crystaltokyo.com
Subject:
subscribe as-devel
Welcome to the team.
>
> julian (topeka)
Happy hacking :)
Sasha Vasko