[as-devel] Re: afterstep 1.8.8 patches
Jon Nelson (jnelson@boa.org)
Mon, 29 Jan 2001 20:26:55 -0600
> > 1. hotkey routine modified to prevent strange menu entries like "XtermX
> X" where
> > the original entry was
> >
> > Exec "Xterm&X" exec xterm &
>
> What you mean strange menu entries? If menu item has a hotkey defined like
> above,
> the hot key is supposed to be shown in the right side of the menu entry. Is
> that what
> you want to prevent ?
Without my patch, I get menu entries where the hotkey shows up twice --
once in the "name", and again in the hotkey.
Example above you appear as [ "XtermX X" ]
(brackets denote visual box)
> > 2. toplevel Makefile.in removes files it creates (the unpatched one
> leaves
> > some files around, making diffs inconsistent)
>
> There is a script included in tools directory : tools/makeasclean
> that will get rid of those files. Also tools/makeaspatch will make a patch
> for you,
> checking several things along the way. Patch will be placed into
> /tmp/patch.
> You must use these scripts if you wish to produce officially accepted
> patches.
> On the other side make clean is not supposed to get rid of leftover files.
make distclean
has always been the accepted way of completely cleaning up after
any building, including configure. I see some duplicity in what make distclean
and tools/makeasclean both do.
> > 3. Place modules in an arbitrary directory, in Debian's case,
> > /usr/lib/afterstep as per FHS
Removed in 1.8.8-4 as per our discussion today. Moved back to /usr/X11R6/bin!
I'll have a -4 patch available soon!
--
"We all enter this world in the same way: naked; screaming; soaked in
blood. But if you live your life right, that kind of thing doesn't have
to stop there." -- Dana Gould
Jon Nelson
jnelson@boa.org