"bug" report: missing lines from functions.c

• Messages sorted by: [ date ][ subject ][ author ]
• Next message: =?EUC-KR?B?sei6tML5?= "AfterStep 1.5beta5 have a bug in I18N code."
• Previous message: Andrew Sullivan "Patch (can't put on f.a.o)"

Hi Guylhem,

I noticed this and fixed it in my local copy of version 1.0, but never
got around to emailing a bug report in. In <src/afterstep/functions.c>,
the lines (1127--1131)

      /* Make CirculateUp and CirculateDown take args. by Y.NOMURA */
      if (action && !matchWildcards (action, t->name)
	  && !matchWildcards (action, t->icon_name) && t->class.res_name
	  && !matchWildcards (action, t->class.res_name))
	continue;

would be better as:

      /* Make CirculateUp and CirculateDown take args. by Y.NOMURA */
      if (action && !matchWildcards (action, t->name)
	  && !matchWildcards (action, t->icon_name) 
+         && t->class.res_class
+         && !matchWildcards (action, t->class.res_class)
          && t->class.res_name 
          && !matchWildcards (action, t->class.res_name))
	continue;

I found that a tcl/tk application I use only has a consistent
res_class name, and I wanted a key to circulate through its windows
(so I needed this addition).

Hopefully you agree and this can get added to the distribution.  Keep
up the good work.

Cheers,
Michael.

• Next message: =?EUC-KR?B?sei6tML5?= "AfterStep 1.5beta5 have a bug in I18N code."
• Previous message: Andrew Sullivan "Patch (can't put on f.a.o)"