Re: fixed patch

• Messages sorted by: [ date ][ subject ][ author ]
• Next message: Andrew Sullivan "Final version of FAQ included"
• Previous message: Michal Vitecek "Re: fixed patch"

Michal Vitecek wrote:
> 
>  hello,
> 
>  i fixed the patch because patch version 2.1b screamed about the \ No
>  newline thing in the patch file.
> 

Ok, the problem was that there was no newlines in two files in
1.5beta5. Therefore the was nothing I could do to fix it, and make patch
usefull
for everyone, becouse depending on patch's version it will treat those
new line
errors differently :
v 2.1b : will error out as mulformed patch
v 2.5  : will work fine

if you modify patch file by removing "/No new line" messages, it will be
all around :
v 2.1b : will work fine
v 2.5  : will error out, generating .rej files

I believe we should all upgrade to the latest version of patch, and make
this version 
available from the ftp site's devel directory.
we should also display FAT MESSAGE about this problem.

This problem is not unique for us, quite often you can download patches
for different things with the same problem. As example - 
patch for GIMP from 1.0.0 to 1.0.1.
Ethan's patch 05 for beta4 :)


>  sasha: please, before making other patches, make sure there are no lines
>  with that. thanks

Ever since problems with my patch 08 for beta4, I'm doing my best to
make sure,
that there always are new lines in new code, But I cannot help it if
there are no
new lines in original code. Therefore we need to check for it, every
time we
are releasing new version. 


> --
>                         fuf
> 

Sasha

• Next message: Andrew Sullivan "Final version of FAQ included"
• Previous message: Michal Vitecek "Re: fixed patch"